Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssd1306: Refactor display options #77

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

czechbol
Copy link
Contributor

I hit an issue where I needed to horizontally mirror the image and I could not figure out how to do it with the current state of the implementation.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.1%. Comparing base (f9d4688) to head (f76a578).

Files with missing lines Patch % Lines
ssd1306/ssd1306smoketest/ssd1306smoketest.go 0.0% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #77     +/-   ##
=======================================
- Coverage   47.1%   47.1%   -0.1%     
=======================================
  Files         83      83             
  Lines      10270   10280     +10     
=======================================
- Hits        4842    4837      -5     
- Misses      5251    5263     +12     
- Partials     177     180      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maruel maruel merged commit 853aec6 into periph:main Oct 21, 2024
8 checks passed
@czechbol czechbol deleted the ssd1306/refactor-opts branch October 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants