-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max7219 LED Driver #79
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
+ Coverage 47.1% 47.8% +0.7%
=======================================
Files 83 85 +2
Lines 10280 10548 +268
=======================================
+ Hits 4839 5041 +202
- Misses 5261 5318 +57
- Partials 180 189 +9 ☔ View full report in Codecov by Sentry. |
@maruel Is there something broken? It's showing a fail on codecov/project. |
Can you rebase on main? I just merged #80 which should fix the regression because I just reenabled codecov but the project coverage was too low. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few minors comments but nothing really blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few other items but they can be done in a follow up.
Thanks! |
This commit adds a driver for the Maxim 7219 LED Driver.