Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max7219 LED Driver #79

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Max7219 LED Driver #79

merged 4 commits into from
Oct 27, 2024

Conversation

gsexton
Copy link
Contributor

@gsexton gsexton commented Oct 26, 2024

This commit adds a driver for the Maxim 7219 LED Driver.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 76.11940% with 64 lines in your changes missing coverage. Please review.

Project coverage is 47.8%. Comparing base (9ab07ba) to head (9a92300).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
max7219/max7219.go 75.0% 55 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #79     +/-   ##
=======================================
+ Coverage   47.1%   47.8%   +0.7%     
=======================================
  Files         83      85      +2     
  Lines      10280   10548    +268     
=======================================
+ Hits        4839    5041    +202     
- Misses      5261    5318     +57     
- Partials     180     189      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsexton
Copy link
Contributor Author

gsexton commented Oct 26, 2024

@maruel Is there something broken? It's showing a fail on codecov/project.

@maruel
Copy link
Member

maruel commented Oct 27, 2024

Can you rebase on main? I just merged #80 which should fix the regression because I just reenabled codecov but the project coverage was too low.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few minors comments but nothing really blocking.

max7219/example_test.go Outdated Show resolved Hide resolved
max7219/example_test.go Outdated Show resolved Hide resolved
max7219/max7219.go Outdated Show resolved Hide resolved
max7219/max7219.go Outdated Show resolved Hide resolved
max7219/max7219.go Outdated Show resolved Hide resolved
max7219/max7219.go Show resolved Hide resolved
max7219/max7219.go Outdated Show resolved Hide resolved
Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few other items but they can be done in a follow up.

max7219/max7219.go Show resolved Hide resolved
max7219/max7219.go Show resolved Hide resolved
max7219/max7219.go Show resolved Hide resolved
max7219/max7219.go Show resolved Hide resolved
max7219/max7219.go Show resolved Hide resolved
@maruel maruel merged commit c0037af into periph:main Oct 27, 2024
10 checks passed
@maruel
Copy link
Member

maruel commented Oct 27, 2024

Thanks!

@gsexton gsexton deleted the max7219 branch November 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants