Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcp23xxx: Add GPIO Group support #92

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

gsexton
Copy link
Contributor

@gsexton gsexton commented Feb 9, 2025

Fixes #17

@maruel
Copy link
Member

maruel commented Feb 10, 2025

Do I understand you need to rebase first so the tests pass?

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once tests pass.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 54.76190% with 57 lines in your changes missing coverage. Please review.

Project coverage is 51.3%. Comparing base (cad2275) to head (f4e4334).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
mcp23xxx/group.go 54.2% 47 Missing and 8 partials ⚠️
mcp23xxx/mcp23xxx.go 66.7% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #92     +/-   ##
=======================================
+ Coverage   49.8%   51.3%   +1.5%     
=======================================
  Files         91     100      +9     
  Lines      11867   12853    +986     
=======================================
+ Hits        5914    6599    +685     
- Misses      5695    5976    +281     
- Partials     258     278     +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsexton gsexton merged commit 5bcc204 into periph:main Feb 13, 2025
10 checks passed
gsexton added a commit to gsexton/devices that referenced this pull request Feb 15, 2025
* Add GPIO Group support to mcp23xxx

* Add unit tests for group

* Fix unit test

* add file

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Direct Register Access for MCP23xxx
2 participants