Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for signed tags #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for signed tags #74

wants to merge 2 commits into from

Conversation

MarkusH
Copy link

@MarkusH MarkusH commented Feb 1, 2015

No description provided.

@peritus
Copy link
Owner

peritus commented Nov 9, 2015

Hey @MarkusH, thanks for this pull request and greetings to where ever you are on your round-the-world trip when reading this :)

Some questions we should answer before merging this:

  • Could there be a good default for this ?
  • Could we auto-detect that the vcs is set up to sign tags ?
  • Would it make sense to also sign commits ?
  • Would it make sense to make signing tags vs signing commits configurable separately ?

Note to self: This also needs tests, and mercurial support.

@peritus peritus changed the title Added support to sign Git tags Support for signed tags Nov 9, 2015
@MarkusH
Copy link
Author

MarkusH commented Nov 9, 2015

Hey @peritus thanks for getting back to me. Let me answer your questions as good as I remember:

  1. False, as you need a working GPG setup with your own PK
  2. Hard to tell and given that's it most likely only be used by a few people I think it's not necessary worth the effort in the beginning. Maybe in the future.
  3. I've never signed commits. And quite frankly, checking out commits might be common, but what are the odds that you have two commits with the same hash on the same repository. I personally only use commit hash if I'm the author of the package or know and trust the authors.
  4. Not necessary as per 3.

I don't use HG so I'd ask you for that integration.

@kynan
Copy link

kynan commented Feb 15, 2016

@MarkusH This has gone stale, any chance of rebasing please?

@peritus This closely relates to #58, which of these two feels more "ready" to you? Would be great to have both!

@MarkusH
Copy link
Author

MarkusH commented Feb 15, 2016

Closing in favor of #58 seems to make sense when that adds signing support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants