corpus.t, htmlbat.t: don't write to t directory during testing
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and remove some `ok 1;` statements that can never fail. Also, delete the `$DEBUG` variable.
This test has never worked right since it was introduced in commit ebf9054. The result of a plain s/// is a boolean, not the replacement string.
Previously it was mostly a mix of 4-space and 2-space indentation, but I can't explain the 6-space indentation of the find() callback.
This cleans up after commit c4a9bb1, which overlooked the (now unused) $cwd variable and didn't consolidate the module loading sections. Also remove the `note` reporting that we've found the test corpus, now that we're no longer doing a search that can fail.
Otherwise testing fails with a read-only t/ directory.
Also, remove the whole `$skippy` logic because it has never worked. In
order for `skip()` to function, it needs to be placed inside a `SKIP:`
block. Otherwise the whole test just aborts with:
Label not found for "last SKIP" at .../Test/More.pm line 1409.
# Looks like your test exited with 255 just after 1.
Having .xml_out files lying around is mainly useful for debugging failing tests, but shouldn't be the default because otherwise testing fails if t/ is a read-only directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests cause problems if run with a read-only
tdirectory (see also Perl/perl5#22352).Also, lots of little clean-ups:
usestatements$skippy, filename length checks)