Fix incorrect draw target when applying filter to a framebuffer #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perminder-17
pushed a commit
that referenced
this pull request
Oct 9, 2024
feat: contributor guidelines in hindi updated
perminder-17
pushed a commit
that referenced
this pull request
Oct 9, 2024
feat: added spanish translation to contributor_guidelines.md
perminder-17
pushed a commit
that referenced
this pull request
Dec 15, 2024
add p5v1 missing images to `manual-test-exmples/type`
perminder-17
added a commit
that referenced
this pull request
Aug 17, 2025
* Fixed loop variable in createFileInput() docs (dom.js) * Bump serialize-javascript and mocha Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 6.0.2 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `serialize-javascript` from 6.0.0 to 6.0.2 - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.0...v6.0.2) Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: serialize-javascript dependency-type: indirect - dependency-name: mocha dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Bump elliptic from 6.6.0 to 6.6.1 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.6.0 to 6.6.1. - [Commits](indutny/elliptic@v6.6.0...v6.6.1) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * added instance of video in callback * Revert "fix: push() ignoring the ColorMode processing#7402" * Fix typos * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Add @dpanshug for doc * Update reference.js * Update reference.js.map * Update books.xml * Update error_helpers.js * Update sketch.js * Update sketch.js * Update p5.Table.js * Update p5.Image.js * Update pixels.js * Remove generated reference.js.map from PR * Restore generated file to match upstream main * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * 1.11.8 * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrew McWhae <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Soubhagya Mohapatra <[email protected]> Co-authored-by: kit <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: raclim <[email protected]> Co-authored-by: Perminder Singh <[email protected]> Co-authored-by: ksen0 <[email protected]> Co-authored-by: sukrucildirr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was that, when drawing to a framebuffer,
tex0should be the framebuffer and not the main canvas. I've added a variable calledtargetwhich will be either the active framebuffer orthis.