pulsar integration #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review.mp4 |
danyi1212
requested changes
Sep 22, 2024
broadcaster/_backends/pulsar.py
Outdated
|
|
||
| async def next_published(self) -> Event: | ||
| while True: | ||
| msg = await self._run_in_executor(self._consumer.receive) |
There was a problem hiding this comment.
Better wrap everything inside this while in a try except all, so that an exception will not crash the consumer.
|
@danyi1212 ... |
danyi1212
approved these changes
Sep 23, 2024
daveads
force-pushed
the
pulsar-integration
branch
from
81e8a93
to
a295c17
Compare
|
@danyi1212 waiting for workflow approval |
|
@danyi1212 Found out just updating you on my progress. |
Everything works fine currently on a test branch... https://github.com/daveads/broadcaster/actions/runs/11015265520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulsar integration Feature #583
permitio/opal#583