Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci for cedar-agent #35

Merged
merged 32 commits into from
Oct 8, 2024
Merged

ci for cedar-agent #35

merged 32 commits into from
Oct 8, 2024

Conversation

EliMoshkovich
Copy link
Contributor

No description provided.

RazcoDev
RazcoDev previously approved these changes Sep 29, 2024
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@omer9564 omer9564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general,
1 comment about always tagging latest
Notice that the or checks fail, i guess you need to run cargo update or rebase main

.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/pr_test.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Show resolved Hide resolved
omer9564
omer9564 previously approved these changes Oct 8, 2024
@EliMoshkovich EliMoshkovich merged commit 70ab0a6 into main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants