Optimize publishing #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roekatz
commented
Jun 20, 2023
roekatz
commented
- Less reconnections to DB
- Better ordering safety by notifying all subscribers through broadcaster (when configured), otherwise local subscribers are notified immediately - regardless of ordering of messages on the underlying broadcaster channel (eg. Postgres NOTIFY which guarantees order).
To avoid some of the reconnections
roekatz
force-pushed
the
rk/optimize-publish
branch
from
3bac226
to
a2e77b5
Compare
To have better ordering safety of messages (local subscribers won't be notified much before remote ones)
roekatz
force-pushed
the
rk/optimize-publish
branch
from
53f2a21
to
4f34927
Compare
orweis
reviewed
Aug 6, 2023
| # Unsubscribe from internal events | ||
| logger.debug("Unsubscribing from ALL TOPICS") | ||
| await self._event_broadcaster._unsubscribe_from_topics() | ||
| pass |
There was a problem hiding this comment.
I'm not sure I understand why you dropped the _unsubscribe_from_topics ?
| @@ -264,3 +264,6 @@ async def __read_notifications__(self): | |||
| ) | |||
| except: | |||
| logger.exception("Failed handling incoming broadcast") | |||
| logger.info( | |||
There was a problem hiding this comment.
Seems more like a debug message than info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.