Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal queues for pubsub message transmission to clients. #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaulk
Copy link

@shaulk shaulk commented Aug 23, 2023

No description provided.

@shaulk shaulk force-pushed the shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to branch from 8015b9d to 43f84cb Compare August 23, 2023 11:19
await self._queues[subscription].put(data)

async def _handle_queue(self, subscription: Subscription):
while True:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should catch CancelledError and quit the while

@shaulk shaulk force-pushed the shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to branch from 43f84cb to 67c38cb Compare August 23, 2023 11:51
@shaulk shaulk force-pushed the shaul/per-7672-add-internal-queues-for-pubsub-message-transmission-to branch from 67c38cb to df8ae7e Compare August 23, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants