-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both Pydantic v1 and v2 #65
Conversation
These tests will fail until permitio/fastapi_websocket_rpc#24 is merged and published, because this PR requires |
Of course :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in permitio/fastapi_websocket_rpc#24.
Don't worry about the versions, I'll release those once we merge.
@roekatz I notice there's a timeout error for one of the tests. I can't really infer from the logs what's going on there, and if it's related to the pydantic changes ... |
@ff137 I'll fix it separately, I don't think it's related to your changes |
pydantic is currently pinned to <2. This PR unpins and provides support for both v1 and v2, without deprecation warnings.
Edit:
fastapi_websocket_rpc
, which is in the requirements here, seems to also be pinned to <2. So, this PR is contingent on this one being released first: permitio/fastapi_websocket_rpc#24. Version there is bumped to 0.1.25, so this PR is set to requirefastapi_websocket_rpc~=0.1.25