Skip to content

Commit

Permalink
Merge pull request #647 from permitio/roe/per-10558-fix-failing-opal-…
Browse files Browse the repository at this point in the history
…tests-in-github-actions

Fix data updater tests
  • Loading branch information
roekatz committed Aug 29, 2024
2 parents b323d1e + 3c77346 commit 5a091e6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion packages/opal-client/opal_client/tests/data_updater_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ async def test_data_updater_with_report_callback(server):
res = await session.get(CHECK_DATA_UPDATE_CALLBACK_URL)
current_callback_count = await res.json()

proc2 = None
try:
proc = multiprocessing.Process(target=trigger_update, daemon=True)
proc.start()
Expand Down Expand Up @@ -283,7 +284,8 @@ async def test_data_updater_with_report_callback(server):
finally:
await updater.stop()
proc.terminate()
proc2.terminate()
if proc2:
proc2.terminate()


@pytest.mark.asyncio
Expand Down
2 changes: 1 addition & 1 deletion packages/requires.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ idna>=3.3,<4
typer>=0.4.1,<1
fastapi>=0.109.1,<1
fastapi_websocket_pubsub==0.3.7
fastapi_websocket_rpc>=0.1.21,<1
fastapi_websocket_rpc==0.1.25
gunicorn>=22.0.0,<23
pydantic[email]>=1.9.1,<2
typing-extensions;python_version<'3.8'
Expand Down

0 comments on commit 5a091e6

Please sign in to comment.