Webhook: Fix not listening to notifications when no broadcaster #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
roekatz
force-pushed
the
rk/fix-webhook-without-broadcaster
branch
from
8aaebde
to
8cf1ac3
Compare
roekatz
force-pushed
the
rk/fix-webhook-without-broadcaster
branch
from
8cf1ac3
to
63e1323
Compare
shaulk
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest fixes to broadcaster stability introduced refactor to listening to webhook notifications task.
Previously we haven't make sure broadcaster listening context was entered before listening,
Now we always do - although when broadcaster is not configured - webhook notifications won't be listened at all.
This PR fixes that bug and supports both scenarios.