Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiPolicySource: Log errors in bundle init/update before retrying #500

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

roekatz
Copy link
Collaborator

@roekatz roekatz commented Sep 20, 2023

Currently fails silently and keeps retrying indefinitely if fails to fetch or extract bundle from api source.
Thus if bundle tar file has bad format, user won't have any information about the issue.

@roekatz roekatz requested a review from orweis September 20, 2023 11:54
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 7102de0
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/650afb87f4a91700088a7af7

@roekatz roekatz requested a review from asafc September 20, 2023 12:36
Copy link
Contributor

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, but a few notes for improvement

@roekatz roekatz force-pushed the rk/log-api-policy-bundle-errors branch from c8876d6 to 7102de0 Compare September 20, 2023 14:02
@roekatz roekatz merged commit a7176dc into master Sep 20, 2023
7 checks passed
@roekatz roekatz deleted the rk/log-api-policy-bundle-errors branch September 20, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants