Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: fix secret leakage in errors. #503

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Security: fix secret leakage in errors. #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/opal-common/opal_common/authentication/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def verify_logged_in(verifier: JWTVerifier, token: Optional[str]) -> JWTClaims:
logger.debug("JWT verification disabled, cannot verify requests!")
return {}
if token is None:
raise Unauthorized(token=token, description="access token was not provided")
raise Unauthorized(description="access token was not provided")
claims: JWTClaims = verifier.verify(token)
subject = claims.get("sub", "")

invalid = Unauthorized(token=token, description="invalid sub claim")
invalid = Unauthorized(description="invalid sub claim")
if not subject:
raise invalid
try:
Expand Down
Loading