Add missing x-amz-content-sha256 header when generating headers for…
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… s3 authorization. closes permitio#518
✅ Deploy Preview for opal-docs canceled.
|
…cking a bundle from an S3 bucket. Originally was hard-coded to `us-east-1`. For backwards compatibility, if the new option is not provided, we will default back to `us-east-1`.
asafc
reviewed
Nov 30, 2023
|
thanks for this contribution! @roekatz will review when he next gets a chance. |
|
Is there anything I can do to help move this along? We are working on setting up our OPAL infrastructure, and this is currently an impediment unless we run local dev builds. |
roekatz
requested changes
Mar 19, 2024
…redundant if statement. - Fix duplicated value in documentation.
roekatz
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Great!
@kbalthaser - Thanks for that PR, it's highly appreciated 🚀 🏆
|
@kbalthaser Just fix the pre-commit and I'll merge? |
|
@roekatz I think I got those fixed now. |
|
@danielbass37 / @gemanor - please offer @kbalthaser some swag - in appreciation of his contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… s3 authorization.
Also adds the ability to configure the AWS region when pulling from S3. For back-compat, the code defaults to the original hardcoded
us-east-1value.Closes #518
Fixes Issue
Fixes #518
Check List (Check all the applicable boxes)