Rename DATA_STORE_CONN_RETRY to DATA_UPDATER_CONN_RETRY
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
roekatz
force-pushed
the
rk/rename-data-store-conn-retry
branch
from
f2b3199
to
864d9d8
Compare
roekatz
force-pushed
the
rk/rename-data-store-conn-retry
branch
from
864d9d8
to
2f6f6e7
Compare
With backwards compatibility
roekatz
force-pushed
the
rk/rename-data-store-conn-retry
branch
from
2f6f6e7
to
b31494b
Compare
orishavit
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration variable sets the retry params for the data updater that fetches data from server.
The new name is more inline with the name of the similar variable for the policy updater (that fetches policy from server) -
POLICY_UPDATER_CONN_RETRYThe older name (
DATA_STORE_CONN_RETRY) was confusingly matching the retry configuration of the policy store client (OPA) - which actually sets both policy & data.Backwards compatibility is kept - there would be no breakage for whomever is already using the deprecated name
DATA_STORE_CONN_RETRY.