Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 3.11 and 3.12 to tests CI #570

Merged
merged 5 commits into from
Apr 21, 2024

Conversation

danyi1212
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 310fb94
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/66213767285e3600083d54bc

@danyi1212 danyi1212 requested a review from roekatz April 18, 2024 09:37
@danyi1212 danyi1212 self-assigned this Apr 18, 2024
Copy link
Collaborator

@roekatz roekatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment would be that the PR does more than its title suggests.
But looks good 👍

Oh actually - if we're now supporting 3.11 & 3.12 we should reflect that in pypi.
This made me take a look at packages/opal-*/setup.py and awkwardly we report supporting 3.7-3.9 + require min version 3.7 which is out of date for a while now.
Might be a good chance to refresh those values.

@danyi1212 danyi1212 requested a review from roekatz April 18, 2024 14:27
@danyi1212 danyi1212 merged commit 6e04636 into master Apr 21, 2024
12 checks passed
@danyi1212 danyi1212 deleted the dan/per-9639-fix-snyk-issues-in-opal branch April 21, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants