Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove extra columns improperly mentioned in opal client config vars … #597

Merged

Conversation

thilak009
Copy link
Contributor

@thilak009 thilak009 commented Jun 9, 2024

Fixes Issue

Currently the OPAL Client Configuration Variables section has incorrectly rendered table due to incorrect syntax in configuration.mdx file.
This PR fixes that by removing that invalid syntax(there were extra incorrectly defined columns)

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Adding the current state of the docs page for this section

Screenshot 2024-06-09 at 8 20 54 PM

Note to reviewers

also adjusted the indentation of the configuration variables to match with the style of the rest of the file

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for opal-docs ready!

Name Link
🔨 Latest commit 3d71551
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/6665c2270c9c20000874b681
😎 Deploy Preview https://deploy-preview-597--opal-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow... how did did we miss this - thanks @thilak009 💯

@orweis orweis merged commit 45a4e7f into permitio:master Jun 9, 2024
12 checks passed
@thilak009 thilak009 deleted the fix/docs-opal-client-config-variables branch June 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants