BasePolicyWatcherTask: Signal stop if broadcaster fails to connect #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
|
Tests and pre-commit are failing |
roekatz
force-pushed
the
rk/raise-broadcaster-conn-failure-from-watcher-task
branch
2 times, most recently
from
13af435
to
837212b
Compare
The tests rely on that, and this value also depends on local git configuration
roekatz
force-pushed
the
rk/raise-broadcaster-conn-failure-from-watcher-task
branch
from
837212b
to
6d80630
Compare
danyi1212
requested changes
Jul 1, 2024
danyi1212
approved these changes
Jul 2, 2024
|
Tests are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked by merging that PR - permitio/fastapi_websocket_pubsub#77
And releasing
fastapi_websocket_pubsub0.3.8Until now
EventBroadcasterwasn't raising an error if listeningBroadcasterchannel failed to connect.Now that it does (see related fix in
fastapi_websocket_pubsub), we should also detect it in theBasePolicyWatcherTaskand end that long lived task so the opal-server worker process closes and restarts (rather than remaining in a static erroneous limbo state)A more fancy implementation would be retrying the failed connection (to avoid unnecessarily restarting the worker), but that could be later improved.