Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dan/per-10200-write-docs-on-how-to-use-opal #612

Merged
merged 9 commits into from
Jul 16, 2024
Merged

dan/per-10200-write-docs-on-how-to-use-opal #612

merged 9 commits into from
Jul 16, 2024

Conversation

danyi1212
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@danyi1212 danyi1212 requested a review from obsd July 7, 2024 23:28
@danyi1212 danyi1212 self-assigned this Jul 7, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 7, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs ready!

Name Link
🔨 Latest commit 3e040b0
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/669645c56595e20008e40d04
😎 Deploy Preview https://deploy-preview-612--opal-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danyi1212 danyi1212 requested review from orweis and asafc July 8, 2024 11:31
@danyi1212 danyi1212 marked this pull request as ready for review July 14, 2024 15:39
obsd
obsd approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@obsd obsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix all feedback and approved

@danyi1212 danyi1212 merged commit e5f5dba into master Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obsd obsd obsd approved these changes

@orweis orweis Awaiting requested review from orweis

@asafc asafc Awaiting requested review from asafc

Assignees

@danyi1212 danyi1212

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyi1212 @obsd