Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dan/per-10298-fix-relative-imports-and-import-conflicts-in-opal #618

Merged
merged 7 commits into from
Jul 23, 2024
Merged

dan/per-10298-fix-relative-imports-and-import-conflicts-in-opal #618

merged 7 commits into from
Jul 23, 2024

Conversation

danyi1212
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@danyi1212 danyi1212 requested a review from roekatz July 14, 2024 10:35
@danyi1212 danyi1212 self-assigned this Jul 14, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 14, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 0310701
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/669f99d086bc8a0008f7f58d

omer9564
omer9564 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@omer9564 omer9564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/opal-common/opal_common/authentication/casting.py Show resolved Hide resolved
scripts/gunicorn_conf.py Show resolved Hide resolved
@danyi1212 danyi1212 merged commit d42310b into master Jul 23, 2024
12 checks passed
@danyi1212 danyi1212 deleted the dan/per-10298-fix-relative-imports-and-import-conflicts-in-opal branch July 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omer9564 omer9564 omer9564 approved these changes

@roekatz roekatz Awaiting requested review from roekatz

Assignees

@danyi1212 danyi1212

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyi1212 @omer9564