Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pypi release #629

Merged
merged 27 commits into from
Aug 1, 2024
Merged

added pypi release #629

merged 27 commits into from
Aug 1, 2024

Conversation

EliMoshkovich
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit c0294d7
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/66aa8d54869d550008f0ccd1

.github/workflows/on_release.yml Show resolved Hide resolved
.github/workflows/on_release.yml Outdated Show resolved Hide resolved
.github/workflows/on_release.yml Outdated Show resolved Hide resolved
.github/workflows/on_release.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@roekatz roekatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because overall looks good and there's no harm.
Did left 2 comments which I still think requires a bit more thinking / testing.

.github/workflows/on_release.yml Show resolved Hide resolved
.github/workflows/on_release.yml Show resolved Hide resolved
@EliMoshkovich EliMoshkovich merged commit 84beb45 into master Aug 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants