Fix OpalServer-EvenBroadcaster integration & other OpalServer refactors #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
2 times, most recently
from
69854c3
to
ac7557e
Compare
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
from
ac7557e
to
82f8421
Compare
roekatz
changed the base branch from
master
to
roe/per-10476-write-opal-application-tests
roekatz
force-pushed
the
roe/per-10476-write-opal-application-tests
branch
from
089592e
to
2dce27b
Compare
Base automatically changed from
roe/per-10476-write-opal-application-tests
to
master
August 29, 2024 12:02
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
from
82f8421
to
bd420e0
Compare
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
from
bd420e0
to
fd22880
Compare
roekatz
changed the title
roekatz
commented
Sep 25, 2024
| @@ -1,7 +1,6 @@ | |||
| idna>=3.3,<4 | |||
| typer>=0.4.1,<1 | |||
| fastapi>=0.109.1,<1 | |||
| fastapi_websocket_pubsub==0.3.7 | |||
There was a problem hiding this comment.
This will be fixed to 0.3.9 once we release fastapi_websocket_pubsub with that fix - https://github.com/permitio/fastapi_websocket_pubsub/pull/82/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventBroadcasterconnection so not to restart process (as a result of recent fix not ignoring connection failure ofEventBroadcaster) - This relies on this PR of fastapi_websocket_pubsubPubSubEndpoint&EventBroadcaster(fromfastapi_websocket_pubsub) in opal-server'sPubSub(use the shared abstraction rather than the LL objects)PubSubresponsible for detecting broadcaster disconnection an triggering the disconnect callbacks (instead of each component taking care of it separately - e.g statistics etc).topics/publisher.py(most of each is just a layer that adds nothing, useful stuff like thePeriodicPublisherwas moved to more appropriate location).OpalServermanaging background tasks.