Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPAL Updated Readme Proposal #658

Merged
merged 4 commits into from
Sep 17, 2024
Merged

OPAL Updated Readme Proposal #658

merged 4 commits into from
Sep 17, 2024

Conversation

gemanor
Copy link
Collaborator

@gemanor gemanor commented Sep 17, 2024

Changes proposed

Update the readme with some new context

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@gemanor gemanor requested a review from orweis September 17, 2024 10:39
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 0f14a19
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/66e966bda86aa20008b6baf2

orweis
orweis approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - just a few suggestions for grammar and correctness

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gemanor and others added 3 commits September 17, 2024 14:23
@gemanor @orweis
Update README.md
0f8d7e3 
Co-authored-by: Or Weis <[email protected]>
@gemanor @orweis
Update README.md
d91759e 
Co-authored-by: Or Weis <[email protected]>
@gemanor @orweis
Update README.md
0f14a19 
Co-authored-by: Or Weis <[email protected]>
@gemanor gemanor merged commit c7790da into master Sep 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orweis orweis orweis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemanor @orweis