feat: refactor login flow and hooks #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gemanor PR is ready for review =) |
35C4n0r
changed the title
vishwamartur
added a commit
to vishwamartur/permit-cli
that referenced
this pull request
Nov 15, 2024
Related to permitio#18 Implement environment management commands for Permit CLI. * Add `env.tsx` in `source/commands` directory to implement the required commands: - `permit env select` uses the existing component from permitio#28. - `permit env copy` takes user input via a component and flags: `--target`, `--conflictStrategy`, and `--scope`. - `permit env member` uses a new `useMemberApi` hook to add users with roles. * Create a hook to get a project-level access token with write permissions for `permit env copy`. * Add `useMemberApi.ts` to create a new hook to add users with roles interactively or via flags. * Add `useProjectToken.ts` to create a hook to get a project-level access token with write permissions. * Add unit tests in `env.test.tsx` for `permit env select`, `permit env copy`, and `permit env member` commands. * Add e2e tests in `env.e2e.tsx` for the basic flow of each command to validate their functionality.
vishwamartur
added a commit
to vishwamartur/permit-cli
that referenced
this pull request
Nov 15, 2024
Related to permitio#18 Implement environment management commands for Permit CLI. * Add `env.tsx` in `source/commands` directory to implement the required commands: - `permit env select` uses the existing component from permitio#28. - `permit env copy` takes user input via a component and flags: `--target`, `--conflictStrategy`, and `--scope`. - `permit env member` uses a new `useMemberApi` hook to add users with roles. * Create a hook to get a project-level access token with write permissions for `permit env copy`. * Add `useMemberApi.ts` to create a new hook to add users with roles interactively or via flags. * Add `useProjectToken.ts` to create a hook to get a project-level access token with write permissions. * Add unit tests in `env.test.tsx` for `permit env select`, `permit env copy`, and `permit env member` commands. * Add e2e tests in `env.e2e.tsx` for the basic flow of each command to validate their functionality. Signed-off-by: Vishwanath Martur <[email protected]>
# Conflicts: # source/commands/login.tsx # source/lib/api.ts
Update lint
|
Closing as it moves to a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #13
Closes #13