Merge pull request #25 from permitio/raz/per-8255-salt-security-list-…

…detailed-role-assignment-panic-in-go-sdk add error check in get users roles
permitio · Nov 7, 2023 · 5510071 · 5510071
2 parents 015a81d + f92dd56
commit 5510071
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/api/users.go b/pkg/api/users.go
@@ -229,6 +229,12 @@ func (u *Users) GetAssignedRoles(ctx context.Context, userKey string, tenantKey
 		u.logger.Error("error listing roles for user:"+userKey, zap.Error(err))
 		return nil, err
 	}
+	if roleAssignments == nil || roleAssignments.RoleAssignmentRead == nil {
+		if roleAssignments.RoleAssignmentRead == nil {
+			emptyRoleAssignments := make([]models.RoleAssignmentRead, 0)
+			return emptyRoleAssignments, nil
+		}
+	}
 	return *roleAssignments.RoleAssignmentRead, nil
 }
 

diff --git a/pkg/tests/integration_test.go b/pkg/tests/integration_test.go
@@ -164,7 +164,9 @@ func TestIntegration(t *testing.T) {
 	userCreate.SetEmail("[email protected]")
 	_, err := permitClient.Api.Users.Create(ctx, userCreate)
 	assert.NoError(t, err)
-
+	res, err := permitClient.Api.Users.GetAssignedRoles(ctx, userKey, tenantKey, 1, 100)
+	assert.NoError(t, err)
+	assert.Len(t, res, 0)
 	// Check error codes when creating a user with existing name
 	_, err = permitClient.Api.Users.Create(ctx, userCreate)
 	assert.Error(t, err)