Don't use response to init Permit Errors after it's already consumed

permitio · Aug 21, 2024 · c87fe7a · c87fe7a
1 parent ef1e865
commit c87fe7a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/enforcement/check.go b/pkg/enforcement/check.go
@@ -63,7 +63,7 @@ func (e *PermitEnforcer) parseResponse(res *http.Response) (*CheckResponse, erro
 
 	bodyBytes, err := io.ReadAll(res.Body)
 	if err != nil {
-		permitError := errors.NewPermitUnexpectedError(err, res)
+		permitError := errors.NewPermitUnexpectedError(err, nil)
 		e.logger.Error("error reading Permit.Check() response from PDP", zap.Error(permitError))
 		return nil, permitError
 	}
@@ -74,13 +74,13 @@ func (e *PermitEnforcer) parseResponse(res *http.Response) (*CheckResponse, erro
 		}{&result}
 
 		if err := json.Unmarshal(bodyBytes, opaStruct); err != nil {
-			permitError := errors.NewPermitUnexpectedError(err, res)
+			permitError := errors.NewPermitUnexpectedError(err, nil)
 			e.logger.Error("error unmarshalling Permit.Check() response from OPA", zap.Error(permitError))
 			return nil, err
 		}
 	} else {
 		if err := json.Unmarshal(bodyBytes, &result); err != nil {
-			permitError := errors.NewPermitUnexpectedError(err, res)
+			permitError := errors.NewPermitUnexpectedError(err, nil)
 			e.logger.Error("error unmarshalling Permit.Check response from PDP", zap.Error(permitError))
 			return nil, permitError
 		}