Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] MoveTo Trees Feedback Revamp #59

Open
amalnanavati opened this issue Aug 30, 2023 · 1 comment
Open

[ROS2] MoveTo Trees Feedback Revamp #59

amalnanavati opened this issue Aug 30, 2023 · 1 comment

Comments

@amalnanavati
Copy link
Contributor

There are two issues with the way MoveTo feedback is currently structured:

  1. Only the MoveTo behavior populates the feedback fields. However, several trees have behaviors before/between/after MoveTo behaviors, which should all be considered part of the "planning" time. Therefore, the feedback should be set at a tree level (TBD how, perhaps by introspecting the current node of the tree? or with a post-tick handler?) so that for any behaviors but MoveTo behaviors it still sends feedback that increments planning time.
  2. The blackboard persists across runs of the tree. As a result, the first feedback message for a tree that doesn't start with a MoveTo behavior will be the last feedback message from the last time the tree was run, until a MoveTo behavior resets the feedback fields in the blackboard.
@amalnanavati amalnanavati changed the title MoveTo Trees Feedback Revamp [ROS2] MoveTo Trees Feedback Revamp Aug 30, 2023
@egordon
Copy link
Collaborator

egordon commented Sep 28, 2023

Once #114 merges, this can be solved using a MoveToVisitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants