-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug where the NUnit-Report fails to generate if the test output contains Virtual Terminal Sequences #2511
Conversation
Hello, thanks for the PR, the test you added is failing. I assume you also want this backported to version 5.x.x ? |
No, we can easily update our test suite to latest version. |
@nohwnd I have fixed the test, it was failling because WindowsPowerShell does not escape the ESC character. Fixed using the ASCII value explicitly. |
Hi @nohwnd , we are blocked by this, we would appreciate if you could review at your earliest convenience. |
/backport rel/5.6.x |
/backport to rel/5.6.x |
Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9744568632 |
PR Summary
The following test will fail to generate an NUnit report:
This will fail because WriteCData does not support writting the ESC character, which is a valid VT sequence.
The fix is to replace the ESC and Bell characters for {ESC} and {BELL}.
According to the Xml CDATA spec, there is no way to escape these characters, other than failing, but we still need to represent them in the NUnit report.
Afte this change, these characters will be represented as by its printable version in the unicode table:
␛
for theESC
(0x1B) and as␇
for theBELL
(0x07) in the resulting Xml CData for example.PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.