Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for Set-ItResult with because, removing trailing comma and redundant "because" #2589

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix formatting for Set-ItResult with because, removing trailing comma and redundant "because" #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/functions/Set-ItResult.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
}

if ($Because) {
[String]$message += ", because $(Format-Because $Because)"
[String]$formatted = Format-Because $Because
[String]$message += ",$($formatted.SubString(0, $formatted.Length - 1))"
}

throw [Pester.Factory]::CreateErrorRecord(
Expand Down
9 changes: 9 additions & 0 deletions tst/functions/Set-ItResult.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ Describe "Testing Set-ItResult" {
}
}

It "Set-ItResult appends the -Because reason to the message" {
try {
Set-ItResult -Skipped -Because "we are forcing it to skip"
}
catch {
$_.Exception.Message | Should -Be "is skipped, because we are forcing it to skip"
}
}

It "Set-ItResult can be called without -Because" {
try {
Set-ItResult -Skipped
Expand Down