Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2018bb4
Set exclude_pseudoclasses to False by default to have the same behavi…
calixteman Apr 25, 2019
0c92e0e
Set default value for --exclude-pseudoclasse to True
calixteman Apr 25, 2019
c59e71d
Finally don't change the default
calixteman Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion premailer/premailer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def __init__(
disable_link_rewrites=False,
preserve_internal_links=False,
preserve_inline_attachments=True,
exclude_pseudoclasses=True,
exclude_pseudoclasses=False,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me nervous. Most people use premailer programmatically rather that the __main__.py endpoint. A change here is expected to break the tests. (At the time of writing I'm waiting for Travis to finish) And potentially it might change peoples implementations when they upgrade to the next version.
Which is right I'm not sure about but I'm sure we should have the same defaults in __main__, this file and in the README.

keep_style_tags=False,
include_star_selectors=False,
remove_classes=False,
Expand Down