Skip to content

Commit

Permalink
fixed an issue in versioning.mk (helm#3653)
Browse files Browse the repository at this point in the history
The MUTABLE_IMAGE_RUDDER variables was using the DOCKER_VERSION instead of MUTABLE_VERSION
```
MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
```
  • Loading branch information
robbert229 authored and adamreese committed Mar 16, 2018
1 parent ff63cde commit a53f93c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion versioning.mk
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ LDFLAGS += -X k8s.io/helm/pkg/version.GitTreeState=${GIT_DIRTY}
IMAGE := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${DOCKER_VERSION}
IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
MUTABLE_IMAGE := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${MUTABLE_VERSION}

DOCKER_PUSH = docker push
ifeq ($(DOCKER_REGISTRY),gcr.io)
Expand Down

0 comments on commit a53f93c

Please sign in to comment.