Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to HACS repo #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

convert to HACS repo #189

wants to merge 1 commit into from

Conversation

wrboyce
Copy link

@wrboyce wrboyce commented Dec 14, 2019

No description provided.

@peterbuga
Copy link
Owner

hi @wrboyce i'm sorry but just like the other opened PR i'm not looking forward to support more or less automatic updaters, if it works it works if not... there are other options ¯\_(ツ)_/¯

@GuyKh
Copy link
Contributor

GuyKh commented Feb 2, 2020

@peterbuga - I truly appreciate your work and your contribution, you made my life much better and I really thank you for that.
I fully respect your right about the intent of this repo.
On the other hand, I do think that HACS have some advantages to it - when it comes to update fetching and keeping the version latest etc.

I suggest some middle-ground when it comes to that idea: Me, or @wrboyce or someone else - will create a fork of the repo and will work on HACS support, pulling updates frequently from your repo to update.

Any thoughts?

@peterbuga
Copy link
Owner

@GuyKh i as well appreciate the offer but i would like to maintain the low-level status of this component (and it's not that widely used... i think)

first of all the component is super basic at it's core and once one gets it to work it rarely needs further updates, 2nd if it's exposed in a simpler way it's highly possible that a lot of people will have problems one way or another and they'll start complaining without providing any logs or decent explanations + possible cross-issues posting on your project and so on (it might easily create a bit of confusion don't you think?)

with all due respect i'm simply not looking for that heat right now, the project has enough install details and there's the easy option to follow the project's progress and that'll make people think twice if they want to update or not (after all, if ain't broke why fix it?) vs. a simple update notification where people will mindlessly click update without reading any release notes.

@GuyKh
Copy link
Contributor

GuyKh commented Feb 2, 2020

@peterbuga I completely understand.
Furthermore, from the nature of this integration, as you mentioned, an increase of heat and number of users, I'm afraid this could make Sonoff (or eWeLink) to take actions against this integration. Or they maybe would put challenges in the connection to their API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants