Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/dedup-history #160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

go-dockly
Copy link

pretty self explanatory I hope the comment helps.
Kuddos for the fantastic library

@peterh
Copy link
Owner

peterh commented May 14, 2023

Sorry for the delay in responding. When I see someone update a branch after opening a pull request, I wait a couple of days to see if more updates are coming, and then I forgot about this.

What is the reason for deduplication? Assuming the reason for deduplication is to keep more unique history, we should deduplicate on history add (not history write). Either way, this is a deliberate change in behaviour, so it needs a persuasive rationale (certainly more than "pretty self explanatory") and possibly a flag to control the behaviour.

If we're going to deduplicate, we should keep the most recent copy, not the oldest.

In a pull request all the "fix" commits should be squashed into the commit that they fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants