Add a migrator for uptrace/bun #8
Conversation
|
This looks great! I'll give a final review within a day or two, but on first glance I think this is shippable. Can you confirm that you've used this for your migrations and it's all good? Thanks so much for the contribution :) |
|
I've tested this locally, and it works and mostly suits my needs. This migrator is a slight modification of the one I've been using for projects. In my projects, I've needed to run go-based migrations alongside the SQL ones for some of my tests. So I allowed passing go migrations through to the migrator, but their hashes ended up being just the name of the go file. I just had to be mindful that the database template wouldn't reflect any of the changes made in the go migration, but it's a source of confusion, so I haven't included it here. |
|
Tests and docs look great, thank you again for contributing! |
Followup to #8, which introduced the new `bunmigrator` package. - Updates the `bunmigrator` documentation to show how to include the postgres driver being used in the tests. - Moves table-initialization logic out of `bunmigrator.Prepare` and into `bunmigrator.Migrate`. This functions the same way, and will make my life slightly easier as I think about removing or replacing the `Prepare` method. (I'm thinking of removing it since it's unnecessary and unused by any of the migrators.) - Updates the main README to mention that `bunmigrator` exists, and thank @BrynBerkeley for contributing it.
This adds a migrator for uptrace/bun. Like golangmigrator, it only supports SQL file migrations as discussed in #7 .