Skip to content

Update/enable all multiplatform targets #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

morisil
Copy link

@morisil morisil commented Jan 30, 2025

No description provided.

@morisil morisil mentioned this pull request Jan 30, 2025
@lppedd
Copy link
Contributor

lppedd commented Jan 31, 2025

Hey @morisil! I had a PR (lppedd#3 - will re-create soon) waiting in line for #129, #130 and lppedd#2.

I see you've simplified the publication mechanism, I think that could be integrated after the KGP update.

@petertrr
Copy link
Owner

Hey @morisil, most of the targets were enabled in #135. IIUC, only binaries.library() and swiftExport, present in this PR, are not yet on main. If you still want to see those targets, could you please rebase your PR on the updated main?

Also, automated dependency updates are already enabled on the repository level, so the versions plugin is redundant.

@lppedd
Copy link
Contributor

lppedd commented Jul 30, 2025

Note that those two functionalities should be enabled by library consumers, not by the library itself.

For example, binaries.library() is only useful if you're going to create an npm package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants