Improve rules and instructions for macOS #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These regular expressions do not make use of extended syntax, therefore the flag -r (GNU sed specific) is not actually needed. The escape sequence '\r' for carriage-return is not portable across sed(1) implementations, use tr(1) instead to achieve the same.
There is no need to have GNU sed on PATH anymore after making the invocations in Makefile portable.
|
Still running Sierra here, needed to checkout this PR to be able to build esp-open-sdk. Thanks! |
nathanpc
added a commit
to innoveworkshop/esp-open-sdk
that referenced
this pull request
Aug 5, 2021
…OS compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits convert and replace the GNU sed commands in Makefile to a portable syntax, which will remove the requirement to modify PATH on macOS. Add instructions which ports need to be installed when using MacPorts instead of Homebrew.