Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce rule on circular dependencies #16

Merged
merged 13 commits into from
Jan 29, 2025
Merged

Enforce rule on circular dependencies #16

merged 13 commits into from
Jan 29, 2025

Conversation

pfazzi
Copy link
Owner

@pfazzi pfazzi commented Jan 26, 2025

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Patrick Luca Fazzi <[email protected]>
@pfazzi pfazzi marked this pull request as draft January 26, 2025 10:42
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Fix test
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 82.07171% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (d0a8e13) to head (6551677).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/must_not_have_circular_dependencies.rs 87.17% 15 Missing ⚠️
src/dsl/project.rs 0.00% 10 Missing ⚠️
src/engine.rs 36.36% 7 Missing ⚠️
src/rust_project.rs 87.03% 7 Missing ⚠️
src/dsl/architectural_rules.rs 89.47% 4 Missing ⚠️
src/dsl/arkitect.rs 88.88% 1 Missing ⚠️
src/rules/must_not_depend_on_anything.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   76.97%   77.71%   +0.73%     
==========================================
  Files          10       12       +2     
  Lines         443      664     +221     
==========================================
+ Hits          341      516     +175     
- Misses        102      148      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add tests
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
Signed-off-by: Patrick Luca Fazzi <[email protected]>
@pfazzi pfazzi marked this pull request as ready for review January 29, 2025 23:10
@pfazzi pfazzi merged commit 5f42191 into main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant