-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PPE profiling for HTTPCache / HTTPCachedFS #356
Conversation
Signed-off-by: KantaTamura <[email protected]>
Signed-off-by: KantaTamura <[email protected]>
Signed-off-by: KantaTamura <[email protected]>
405213a
to
dfd4962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment
pfio/v2/fs.py
Outdated
@@ -154,6 +155,11 @@ def is_forked(self): | |||
assert hasattr(self, 'pid') | |||
return self.pid != os.getpid() | |||
|
|||
@property | |||
def is_trace(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps is_traced
is better grammatically; what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so
Signed-off-by: KantaTamura <[email protected]>
Signed-off-by: KantaTamura <[email protected]>
This PR resolves the
CachedHttpFs
/HttpCache
task in #258Sample program to check tracing
rendering of the output json (

cache_httpcache.json
) file with chrome://tracing is shown belowrendering of the output json (

fs_httpcache.json
) file with chrome://tracing is shown below