Add fixer

pfrenssen · Jan 29, 2024 · 3d992e0 · 3d992e0
1 parent f525910
commit 3d992e0
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/coder_sniffer/Drupal/Sniffs/Semantics/UnsilencedDeprecationSniff.php b/coder_sniffer/Drupal/Sniffs/Semantics/UnsilencedDeprecationSniff.php
@@ -68,7 +68,10 @@ public function processFunctionCall(
 
         if ($tokens[($stackPtr - 1)]['type'] !== 'T_ASPERAND') {
             $error = 'All trigger_error calls used for deprecation must be prefixed by an "@"';
-            $phpcsFile->addError($error, $stackPtr, 'UnsilencedDeprecation');
+            $fix = $phpcsFile->addFixableError($error, $stackPtr, 'UnsilencedDeprecation');
+            if ($fix === true) {
+              $phpcsFile->fixer->addContentBefore($stackPtr, '@');
+            }
         }
 
     }//end processFunctionCall()

diff --git a/tests/Drupal/Semantics/UnsilencedDeprecationUnitTest.inc b/tests/Drupal/Semantics/UnsilencedDeprecationUnitTest.inc
@@ -15,5 +15,5 @@ trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_SOMETHING_
 
 // E_USER_DEPRECATED, so silenced is fine...
 @trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_DEPRECATED);
-//... but unsilenced fails.
+// ... but unsilenced fails.
 trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_DEPRECATED);
diff --git a/tests/Drupal/Semantics/UnsilencedDeprecationUnitTest.inc.fixed b/tests/Drupal/Semantics/UnsilencedDeprecationUnitTest.inc.fixed
@@ -0,0 +1,19 @@
+<?php
+
+/**
+ * @file
+ * Test data for the relaxed version of FunctionUnsilencedDeprecationSniff coding standard.
+ */
+
+// No second parameter, so cannot fail it, both silenced and unsilenced.
+@trigger_error('CommentTestBase is deprecated in drupal 8.4.0');
+trigger_error('CommentTestBase is deprecated in drupal 8.4.0');
+
+// Not E_USER_DEPRECATED, so cannot fail it, both silenced and unsilenced.
+@trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_SOMETHING_ELSE);
+trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_SOMETHING_ELSE);
+
+// E_USER_DEPRECATED, so silenced is fine...
+@trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_DEPRECATED);
+// ... but unsilenced fails.
+@trigger_error('CommentTestBase is deprecated in drupal 8.4.0', E_USER_DEPRECATED);