Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move key ranges via postgres_fdw #566

Merged
merged 48 commits into from
Apr 15, 2024
Merged

Move key ranges via postgres_fdw #566

merged 48 commits into from
Apr 15, 2024

Conversation

EinKrebs
Copy link
Collaborator

No description provided.

@EinKrebs EinKrebs force-pushed the change-key-range-moving branch 2 times, most recently from b7b092e to d9f88e6 Compare March 25, 2024 12:36
@EinKrebs EinKrebs marked this pull request as ready for review March 25, 2024 12:41
Denchick
Denchick requested changes Mar 26, 2024
View reviewed changes
coordinator/provider/coordinator.go Show resolved Hide resolved
coordinator/provider/coordinator.go Show resolved Hide resolved
pkg/datatransfers/data_transfers.go Outdated Show resolved Hide resolved
pkg/datatransfers/data_transfers_test.go Show resolved Hide resolved
qdb/memqdb.go Show resolved Hide resolved
pkg/util/uitl.go Outdated Show resolved Hide resolved
@EinKrebs EinKrebs force-pushed the change-key-range-moving branch 2 times, most recently from 3ea47cd to a101743 Compare March 28, 2024 06:36
Denchick
Denchick requested changes Mar 28, 2024
View reviewed changes
qdb/etcdqdb.go Show resolved Hide resolved
qdb/etcdqdb.go Outdated Show resolved Hide resolved
qdb/memqdb.go Outdated Show resolved Hide resolved
Denchick
Denchick requested changes Mar 29, 2024
View reviewed changes
pkg/models/kr/keyrange.go Show resolved Hide resolved
@EinKrebs
Initial rewrite of MoveKeys
aa8ae5d
@EinKrebs
Refactored condition for key range
dd79dee
@EinKrebs
Check before copying data
a748c55
@EinKrebs
Get next bound actually
d97010a
@EinKrebs
Fixed logic of MoveKeys
3856b0e
@EinKrebs
Add DeleteKeyRangeMove method to EtcdQDB
dff9e4e
@EinKrebs
Change logic of (*qdbCoordinator).Move
d48676f
@EinKrebs
Implemented getKRCondition
d2c00f2
@EinKrebs
Fixed idleness of (*qdbCoordinator).Move
32b845a
@EinKrebs
Fix typo
2674820
@EinKrebs
Fix side-stepping qdb.MoveKeyRangeStarted
b163fbf
@EinKrebs
Change GetTransferTx logic to return nil when no transaction
f30cf78
@EinKrebs
Fix RunCoordinator current transactions logic
b0986ba
@EinKrebs
Add debug logging to qdb
c00a5f8
@EinKrebs
Added & fixed tests
ea1d1ee
@EinKrebs
Fix importing foreign schema
8c5a879
@EinKrebs
Added TODO to etcdqdb.go
69990bc
@EinKrebs
Add user mapping to sender shard
afa1565
@EinKrebs
Delete redundant function
b9b6b27
@EinKrebs
Check for relation existence on both sender & receiver
36f160a
@EinKrebs
Drop old schema on receiver
9f3016c
@EinKrebs
Fixed table names
2927933
@EinKrebs
Fixed copying data
1bbaa23
@EinKrebs
Removed redundant fields & types from DataTransferTransaction
aaedfda
@EinKrebs
Move copyData out of MoveKeys
f8602f1
@EinKrebs
Fixed checking table existence
3b44045
@EinKrebs
Add test for non-existent table on the receiving shard to mover featu…
d36a6b2 
…re tests
@EinKrebs
Added & fixed tests
5fef62c
@EinKrebs
Fix lint
e35397a
@EinKrebs
Added test for moving key range with varchar column type
6d9ecb4
@EinKrebs
Moved GetKRCondition to util package
dd01cfb
@EinKrebs
Removed excess GetKeyRange method from qdbCoordinator
648ec5a
@EinKrebs
Moved GetKRCondition to kr package
bffe04d
@EinKrebs
Fix continuation of key range moves on coordinator startup
826f0f3
@EinKrebs
Added test for continuation of key range moves
00400e4
@EinKrebs
Moved transaction records in etcd to separate namespace
ee1f2a8
@EinKrebs
Fix lint
91a6afa
@EinKrebs
Removed nolint
6753765
@EinKrebs
Add another move recover test
6ee4cb6
@EinKrebs
Add some comments
b2cc4f5
@EinKrebs
Separated table existence & key range key count checks
13c6e74
@EinKrebs
Fix typo in comment
fcfaad3
@EinKrebs
Removed obsolete TODO
d962395
@EinKrebs
Declared missing methods from QDB
fee12a2
@EinKrebs
Add docstrign for DataTransferTransaction
f7a8474
@EinKrebs
Add unit test for GetKRCondition
831c9b3
@EinKrebs
Fix build
80d6e4d
@EinKrebs EinKrebs merged commit 5fee632 into master Apr 15, 2024
26 checks passed
@EinKrebs EinKrebs deleted the change-key-range-moving branch April 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Denchick Denchick Denchick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EinKrebs @Denchick