Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group by in Coordinator SHOW #771

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Group by in Coordinator SHOW #771

merged 5 commits into from
Sep 17, 2024

Conversation

diPhantxm
Copy link
Collaborator

@diPhantxm diPhantxm commented Sep 16, 2024 •
edited
Loading

Tried to make it in more generic way, just in case we want to group in some other queries.
If group by is specified, column and count is returned

@diPhantxm diPhantxm marked this pull request as ready for review September 17, 2024 00:46
EinKrebs
EinKrebs requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@EinKrebs EinKrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out #773, pls

EinKrebs and others added 2 commits September 17, 2024 15:10
@EinKrebs
Some refactoring (#773)
d5656e7 
* Refactor scenario name

* Refactor gram

* Refactor interactor.go
@diPhantxm
fix
c2701f7
@reshke reshke merged commit dd45aa2 into master Sep 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinKrebs EinKrebs EinKrebs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diPhantxm @EinKrebs @reshke