-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing complex queries with deeply nested ASTs #17
base: main
Are you sure you want to change the base?
Conversation
Since any solution to the stack overflow issue would involve pulling in dependencies that most users won't need, I decided to document this issue in the README so downstream applications can increase the stack size as needed for their application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 FWIW, this looks good to me - depending on when the upstream change to prost
lands it might be nice to hold off until that's actually merged, but apart from that it looks good to ship.
@lfittl thoughts on best way to install the protobuf compiler on Windows, for CI? |
Probably install the binary provided on the releases page: https://github.com/protocolbuffers/protobuf/releases/tag/v29.0 (not sure if there is an alias for a current version, but I guess we could pin it) To help me understand the change better, is there a reason we need to add this here, vs didn't need it on |
This PR is built on top of a more recent version of the prost crate, which now relies that your system have the protobuf compiler installed separately. |
Makes sense! I think maybe you can use this GH action to install the compiler in a OS-agnostic way: https://github.com/marketplace/actions/setup-protoc (we already have this forked to https://github.com/pganalyze/setup-protoc for security reasons, so you can probably just go ahead and use that fork?) |
This matches the same behavior in the Ruby gem: pganalyze/pg_query#238
Upstream changes were needed in the prost crate that haven't been merged yet: tokio-rs/prost#785
Without further changes, the test suite would run into a stack overflow. There are some ways around this:
maybe_grow
performance. If someone hasn't put together benchmarks we may want to usegrow
instead.