Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed play and next links to buttons #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jannispaul
Copy link

The play and next elements should be buttons instead of links.

The play and next elements should be buttons instead of links.
@pganssle
Copy link
Owner

Sorry, I'm not the world's best front-end person, what is the advantage of these being buttons instead of links?

Also, can you move the commit from #45 into this one, so that if we merge them they can be merged together?

@jannispaul
Copy link
Author

No worries :) It bugged me that I couldn't select the play and next links with my keyboard. That's because they dont have href-attributes. But instead of adding hrefs I suggest to use buttons, since they are the semantically correct element to use here. From the MDN documentation:

„Anchor elements are often abused as fake buttons by setting their href to # [...] Use a button instead. In general, you should only use a hyperlink for navigation to a real URL." https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#onclick_events

I tried to merge the commits but don't know how to do it. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants