Update the Makefile for local development #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinclift
changed the title
justinclift
changed the title
justinclift
force-pushed
the
local_dev_v2
branch
from
9d50de4
to
61d059f
Compare
justinclift
changed the title
justinclift
force-pushed
the
local_dev_v2
branch
from
61d059f
to
552e6c8
Compare
justinclift
force-pushed
the
local_dev_v2
branch
from
552e6c8
to
55e7b3f
Compare
|
This seems mostly ok for now, but I'm not sure what approach to take for a Might need to add an optional extra argument to the Will need to think over it a bit more I reckon, and make a follow up PR for that piece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Makefile doesn't really work for local development, and also has a bunch of
maketargets for pushing images to Docker Hub that we should definitely not use any more.This PR removes all of the old
maketargets that are no longer useful, instead organising things to use apgautoupgrade/pgautoupgrade:localdocker image for local development.There is one remaining
maketarget for pushing to Docker Hub,make pushdev, which pushes the local development image to Docker Hub aspgautoupgrade/pgautoupgrade:dev.Seems to work fine in local testing. 😄