Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning due to partially overridden CompressedSparseMatrix::permute #105

Conversation

sebastiangrimberg
Copy link

This problem probably popped up only recently since this file is now being installed correctly is my guess.

@pghysels
Copy link
Owner

Thank you. Indeed some headers were not installed correctly.
I just fixed warning I noticed when compiling with clang, or hipcc: 19d22f7
But I'm not seeing this warning you mention for the permute routine. What compiler are you using?
Perhaps I could also just remove the virtual keyword for the permute routine taking 2 vectors?

@sebastiangrimberg
Copy link
Author

Thanks for addressing these! These warnings appear when building a file which includes StrumpackSparseSolverMPIDist.hpp with nvcc using -Wall -pedantic. I don't get the warnings when building STRUMPACK likely because the CUDA compilers are only used where necessary. MFEM uses the CUDA compilers everywhere which leads to the issue with nvcc.

@pghysels
Copy link
Owner

I see lot's of warnings now when compiling with the NVHPC compilers on Perlmutter.
I will try to fix all these.

@pghysels
Copy link
Owner

I fixed a lot of warnings.
I sometimes still see unused variable warnings, for things that are only used in OpenMP pragmas. I'll fix those later.

@sebastiangrimberg
Copy link
Author

Awesome! Looks great thanks, I'll close this PR.

@sebastiangrimberg sebastiangrimberg deleted the sjg/override-warning-fix branch August 31, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants