Remove dynamic_cast from headers #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghysels
reviewed
Sep 27, 2024
src/HSS/HSSMatrixMPI.Schur.hpp
Outdated
| Vhat = DistM_t(grid(), Phi.cols(), Theta.cols()); | ||
| copy(Vhat.rows(), Vhat.cols(), ch0->ULV_mpi_.Vhat(), 0, 0, Vhat, 0, 0, grid()->ctxt_all()); | ||
| } | ||
| (DistM_t& Theta, DistM_t& Vhat, DistM_t& DUB01, DistM_t& Phi) const; |
There was a problem hiding this comment.
I think these 2 lines can be removed. See the failures in the tests
There was a problem hiding this comment.
Thanks, should be fixed in the latest version 👍
AmperesAvengement
force-pushed
the
remove_dynamic_cast_from_headers
branch
from
ab4e58d
to
3c409e5
Compare
AmperesAvengement
force-pushed
the
remove_dynamic_cast_from_headers
branch
from
3c409e5
to
4055b25
Compare
|
There is something wrong in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing
dynamic_castin headers has been observed to cause segfaults when modules linking to Strumpack are compiled without RTTI support since they have undefined behaviour. This can be fixed by moving thedynamic_castout of the header