Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix building the API reference. #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

craigcitro
Copy link

Why? docs are great

I noticed the docs have an empty API reference page; a quick check locally seems to confirm the problem is that the usual sphinx sys.path adjustments predate moving the source into src/hypercorn; this PR fixes the path accordingly.

(Happy to remove the ../ entry too, but wasn't sure if something else has quietly grown a dep on that in the docs.)

Why? docs are great

I noticed the docs have an empty API reference page; a quick check locally
seems to confirm the problem is that the usual sphinx `sys.path` adjustments
predate moving the source into `src/hypercorn`; this PR fixes the path
accordingly.

(Happy to _remove_ the `../` entry too, but wasn't sure if something else has
quietly grown a dep on that in the docs.)
@bmwant
Copy link

bmwant commented Aug 31, 2024

@carlopires how to reproduce your issue? locally works for me with make html
Screenshot 2024-08-31 at 4 35 50 PM

Although, I see that official RTD have this page missing https://hypercorn.readthedocs.io/en/latest/reference/api.html.
But maybe it needs just another rebuild/republish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants