Skip to content

Issue #4 resolved #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RudraCodesForU
Copy link
Contributor

Proposed Changes are addressed -

  1. More descriptive names of the DGM in the drop down menu.
  2. For a given DGM, each CI test should be a line in the plots.
  3. CI Test, effect size, and Significance level selection boxes should be removed.
  4. A Sample size selection box should be added.
  5. The Calibration plot should be: Type 1 error vs significance level, where the significance level varies from 0 to 1. In the significance plot, each line should represent one CI test.
  6. The power plot should be: power vs effect size. The effect size should vary from 0.2 to 1. The significance level for the power plot should be fixed to 0.05. There should be lines for each CI test for the DGM.
  7. Each row of plots should have the calibration and power plot for a specified sample size.
  8. For each DGM, also show the equation for the DGM above the plots.

@ankurankan
Copy link
Member

@RudraCodesForU This does not seem to be working for me. I am guessing you had some issues with resolving merge conflicts.

@RudraCodesForU
Copy link
Contributor Author

@ankurankan, previously, I was having issues with resolving merge conflicts but now the code is cleanly mergeable, is there still any issues which persists?

@ankurankan
Copy link
Member

@RudraCodesForU Did you do the merge on github? If yes, you will need to pull changes (git pull) from your remote branch to local to see the current version of the code. You will see that the webpage is broken currently.

@RudraCodesForU
Copy link
Contributor Author

@ankurankan , Changes have been perfromed , conflicts resolved , there was conflict because my fork was outdated and the changes performed in the upstream , so merge conflicts arises.

@RudraCodesForU
Copy link
Contributor Author

@ankurankan , Pls look into the PR now there are no conflicts

@ankurankan
Copy link
Member

@RudraCodesForU This does not seem to be working for me anymore. I do not get any options in the dropdown menu for DGM and sample size. I also see the following error in the console as soon as the page loads:

app.js:170 Uncaught SyntaxError: Unexpected identifier 'labels' (at app.js:170:13)

@RudraCodesForU
Copy link
Contributor Author

@ankurankan , sry for the delay , the app.js should have any error now. You can look into the PR for review

@ankurankan
Copy link
Member

@RudraCodesForU Sorry for the delay, could you give me the steps to run this locally. I am getting a file not found error when I load the page.
error

@ankurankan
Copy link
Member

@RudraCodesForU Could you also check your discord? I sent you a private message a few days back.

@RudraCodesForU
Copy link
Contributor Author

@ankurankan, the "file not found" error has been resolved. Could you please check and get back to me? Also, I’ve checked Discord and accepted your friend request.

@ankurankan
Copy link
Member

@RudraCodesForU I am still unable to reproduce it. Could you share the steps that you are using to run this locally?

@RudraCodesForU
Copy link
Contributor Author

RudraCodesForU commented Jul 16, 2025

@ankurankan , for locally running the code i am just using this - from root folder opening the terminal then - cd web
python -m http.server 8000 the locally running it and made the changes in the equation view was not proper
Screenshot 2025-07-16 180530

@ankurankan
Copy link
Member

@RudraCodesForU I do think you have some other local changes to make it work. For example, the csv path in the code is results/ci_benchmark_summaries.csv, which does not exist in the repo. And also throws a file not found error.

Could you try to clean up your local repo and then fix the issue?

@RudraCodesForU
Copy link
Contributor Author

@RudraCodesForU I do think you have some other local changes to make it work. For example, the csv path in the code is results/ci_benchmark_summaries.csv, which does not exist in the repo. And also throws a file not found error.

Could you try to clean up your local repo and then fix the issue?

@ankurankan, The thing is first we need to run the ci_benchmark.py script then the result folder will be created where the summaries gets stored then we need to run the app.js script.

@ankurankan
Copy link
Member

@RudraCodesForU Could you add the csv file to the repo as well? Because we are hosting a static website, we will need the results file in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants